fix(@angular/build): ensure transitive SCSS partial errors are tracked in watch mode#32883
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
fix(@angular/build): ensure transitive SCSS partial errors are tracked in watch mode#32883clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
…d in watch mode When stylesheet bundling fails due to an error in a SCSS partial, we now ensure that `referencedFiles` are still passed to the `FileReferenceTracker`. This prevents the dependency between the component and the error file from being lost, allowing the component to be correctly rebuilt when the error is fixed.
clydin
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that stylesheet dependencies are tracked even when compilation errors occur, allowing for correct rebuilds once errors are resolved. It adds logic to the Angular compiler plugin to track referenced files in error states and includes regression tests for transitive and deep transitive imports. Review feedback suggests refactoring the new tests into a data-driven loop and consolidating the file tracking logic to avoid duplication between the success and error code paths.
packages/angular/build/src/builders/application/tests/behavior/rebuild-component_styles_spec.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stylesheet bundling fails due to an error in a SCSS partial, we now ensure that
referencedFilesare still passed to theFileReferenceTracker. This prevents the dependency between the component and the error file from being lost, allowing the component to be correctly rebuilt when the error is fixed.