refactor(@angular/cli): deduplicate search roots for MCP projects tool#32886
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
refactor(@angular/cli): deduplicate search roots for MCP projects tool#32886clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
Sorting by length ensures parent directories are processed before children, filtering out overlapping search trees.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a deduplicateSearchRoots utility function to remove overlapping search paths by filtering out subdirectories when a parent directory is already present. The createListProjectsHandler has been updated to apply this deduplication to its search roots. I have no feedback to provide.
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting by length ensures parent directories are processed before children, filtering out overlapping search trees.