This repository was archived by the owner on Feb 26, 2024. It is now read-only.
[feat] add ability to customize template by setting property on controller con...#157
Open
hannahhoward wants to merge 5 commits intoangular:masterfrom
Open
[feat] add ability to customize template by setting property on controller con...#157hannahhoward wants to merge 5 commits intoangular:masterfrom
hannahhoward wants to merge 5 commits intoangular:masterfrom
Conversation
|
+1 |
Author
|
sorry actually commited changes to the dist dir, fixed now. apologies |
Author
|
oops one more piece of code accidentally left in. wow sloppy :) |
Author
|
i now see angular/angular.js#10007 is probably a more elegant solution to this issue, if it moves forward. |
Contributor
|
We'll see. A proposal like yours also came up during today's 1.x meeting. Thanks so much for all of your great comments and feedback, btw. I really appreciate it! It'll probably take me a bit longer than I'd like to get around to coalescing and responding to this wave of feedback following ng-conf, but I'm hoping to have more concrete ideas for these big issues this week. Until then, thanks for your patience! |
ee0fae2 to
1af7b8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...structor
After thinking about #154 I decided a good first step would be to allow you to set a $template on a controller's constructor that will override the default template url returned by componentLoaderProvider.
The syntax is essentially:
This is in line with where #129 is headed and also matches nicely with the Angular 2 component syntax (it could become an annotation instead of a property just like the template annotation in Angular 2). It also allows you to add support for inline templates, so this works:
Anyway, would love feedback if this seems like a good idea.
Also I'm not sure why it shows a bunch of additional changes from what looks like previous commits.