Skip to content

Complete oversized tool-result spill: safe 5k default, error paths, all result paths (#89) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antra-tess merged 2 commits into from
Aug 6, 2026
Merged

Complete oversized tool-result spill: safe 5k default, error paths, all result paths (#89) #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d96a6
feat(tool-results): complete oversized-result spill — safe default, e…
antra-tess Aug 6, 2026
7137547
fix(tool-results): distinct notice + trace when a spill WRITE fails
antra-tess Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import type { Membrane, NormalizedMessage, NormalizedRequest, ContentBlock, YieldingStream } from '@animalabs/membrane';
import { isAbortedResponse } from '@animalabs/membrane';
import { toolResultDataToHistoryString } from './tool-result-history.js';
import {
toolResultDataToHistoryString,
truncateForHistory,
DEFAULT_TOOL_RESULT_INLINE_MAX_CHARS,
} from './tool-result-history.js';

export interface StartStreamResult {
stream: YieldingStream;
Expand Down Expand Up @@ -890,12 +894,17 @@ export class Agent {
// Tool results go as a user message with tool_result blocks. The history
// serializer turns MCP image blocks into `[image: type, size]` so the
// persisted transcript stays small and survives truncation.
//
// This is the direct-Agent-API path (the framework stores results itself
// via buildStoredToolResultContent, with workspace spill). No workspace
// is reachable from here, so the house default cap applies as plain
// truncation — bounded beats unbounded, for errors too.
const content = results.map((r) => ({
type: 'tool_result' as const,
toolUseId: r.id,
content: r.result.isError
? r.result.error ?? 'Unknown error'
: toolResultDataToHistoryString(r.result.data),
? truncateForHistory(r.result.error ?? 'Unknown error', DEFAULT_TOOL_RESULT_INLINE_MAX_CHARS)
: toolResultDataToHistoryString(r.result.data, DEFAULT_TOOL_RESULT_INLINE_MAX_CHARS),
isError: r.result.isError,
}));

Expand Down
Loading
Loading