This repository was archived by the owner on May 21, 2024. It is now read-only.
Added a anime trailers page #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
changed the title
soulcramer
force-pushed
the
add_trailer_page
branch
from
43249ac to
d742f5f
Compare
soulcramer
force-pushed
the
add_trailer_page
branch
from
d742f5f to
d7fb490
Compare
Collaborator
|
I believe the Youtube restriction was in place to discourage non-Youtube sources because we wanted to store them locally as WebM files at some point. |
After reverting to the previous state of the anime page, I noticed that if the latest trailer is not "valid" (currently which is not coming from Youtube and doesn't have a serviceId) we didn't check if there was a valid one. To resolve this issue I've added a trailer parameter to the Anime component which should be the latest valid trailer that we have. Otherwise, we don't display the trailer component.
soulcramer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.