feat(deck-options): handle computeMemory progress#20909
Conversation
I realize that you want to avoid unintended bugs, but as I noted on the issue, most users won't even see the progress in the next version because it will be sped up by >10 times (10.18s → 853ms). So, you might want to consider including this in 2.24 if you feel that this is a low-risk change. |
|
I'd rather keep patch releases for patches rather than sneak functionality in. @mikehardy FYI, open to disagreement. I'm hoping we get to 2.25 pretty quickly |
|
Fewer people even having the potential to see actually means it's even lower priority- same risk of bugs and smaller benefits. We will hopefully do 2.25 quickly- 2.24 (and all its betas) built right off main so we're currently very stable |
| */ | ||
| private fun ProgressContext.toOptimizingPresetString(): String? { | ||
| if (!progress.hasComputeParams()) return null | ||
| private fun ProgressContext.toOptimizingPresetString(): String? = |
There was a problem hiding this comment.
Nit optional: it used to only handle the "Optimizing preset" path, but now also returns "Updating cards…" so maybe rename to toProgressText() or toProgressMessage()
e769873 to
71e113c
Compare
* Enable FSRS * Save * A computeMemory progress dialog is shown Fixes 16642
71e113c to
abfb712
Compare
Purpose / Description
We now show more information than just 'Processing'
Fixes
Approach
computeMemoryHow Has This Been Tested?
computeMemoryprogress dialog is shownScreen_recording_20260430_201904.webm
Learning (optional, can help others)
Out 'Amount' progress indicator abstraction isn't entirely correct. In
computeMemory, we have a label, we do not want to formatAmountas a string, but we do want to use it to display as progress in the dialog.Checklist