fix(github): parse immutable OIDC sub claims#37831
Closed
H-TTTTT wants to merge 1 commit into
Closed
Conversation
Strip @id suffixes from GitHub Actions immutable OIDC subject claims when exchanging app tokens, and harden error handling so a failed token exchange does not crash on an uninitialized Octokit client. Fixes anomalyco#37823
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subclaims with immutable@idsuffixes (repo:owner@id/name@id:...) when exchanging installation tokensoctoRest(p.rest)Fixes #37823
Test plan
bun test src/github-oidc.test.tsinpackages/functionopencode github run(OIDC path, notuse_github_token)repo:owner/name:...subjects still exchange successfully