Skip to content

Not all fanart exsists, so added check for fanart, and default image#2

Open
KasperHelsted wants to merge 4 commits intoanorm:masterfrom
KasperHelsted:master
Open

Not all fanart exsists, so added check for fanart, and default image#2
KasperHelsted wants to merge 4 commits intoanorm:masterfrom
KasperHelsted:master

Conversation

@KasperHelsted
Copy link

No description provided.

@anorm
Copy link
Owner

anorm commented Apr 6, 2016

Thank you for the PR

Some issues to fix:

  1. It doesn't work on channels (i.e. dk/Play extra)
  2. It doesn't work on (some?) shows (i.e. dk/MTV/Awkward)
  3. The image itself does not look good (see below)

kodi-missing-image

@KasperHelsted
Copy link
Author

Should have pushed a fix for the last error, i have no new image for the "No image found". May look into it later.

@anorm
Copy link
Owner

anorm commented Apr 6, 2016

Nice

Could you use urllib.urlencode for converting strings into valid URLs instead of your custom function?

@KasperHelsted
Copy link
Author

I tried it, but it would also change the :// near the http in the begning since it's trying to change any special chars. it would also change all the . and /

Then i would have to deconstruct the url and then use urllib.urlencode on the filename

anorm pushed a commit that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants