Skip to content

Code cleanup & Fix SearchActivity#15

Open
fadeltd wants to merge 4 commits intoantarikshc:masterfrom
fadeltd:master
Open

Code cleanup & Fix SearchActivity#15
fadeltd wants to merge 4 commits intoantarikshc:masterfrom
fadeltd:master

Conversation

@fadeltd
Copy link

@fadeltd fadeltd commented Oct 14, 2019

  • SearchActivity has different toolbar id, so it will crash when trying to search
  • Some codes are just "too java" because of previous kotlin migration, I refactor some of it to make it more "kotlin" and follow the kotlin code style
  • I've checked all the pages and it should be working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant