This repository was archived by the owner on Sep 21, 2023. It is now read-only.
fix: set state when unmounting the component#492
Open
exneval wants to merge 1 commit intoanthonyjgrove:masterfrom
Open
fix: set state when unmounting the component#492exneval wants to merge 1 commit intoanthonyjgrove:masterfrom
exneval wants to merge 1 commit intoanthonyjgrove:masterfrom
Conversation
Signed-off-by: Egi Ginting <exneval.rayz@gmail.com>
Author
|
please kindly check the PR @anthonyjgrove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So PR #316 checked the unmount component for sign in hook, but not for sign out hook,
This PR will do
Signed-off-by: Egi Ginting exneval.rayz@gmail.com