Skip to content

Validate DynamicMessage values before set #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iainmcgin merged 2 commits into from
Jul 8, 2026
Merged

Validate DynamicMessage values before set #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8649276
Validate DynamicMessage values before set
fallintoplace Jul 2, 2026
81afac8
Review fixups: document the encode-skip contract where consumers look
iainmcgin Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/fixed-20260702-212901.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixed
body: '`DynamicMessage::try_set` now rejects `Value`s whose runtime shape does not match the target field descriptor — repeated elements, map keys and values, and nested message descriptor identity included — and `set` consequently panics on shapes it previously accepted and encoded as corrupt tag-only wire output. Invalid values planted through direct mutable field access are omitted during encode (whole field, with `encoded_len` in agreement) instead of corrupting the wire. (#272)'
time: 2026-07-02T21:29:01.000000000Z
Loading
Loading