fix(devcontainer): detect Docker daemon failures via $LASTEXITCODE#66372
Open
MartinCajiao wants to merge 1 commit into
Open
fix(devcontainer): detect Docker daemon failures via $LASTEXITCODE#66372MartinCajiao wants to merge 1 commit into
MartinCajiao wants to merge 1 commit into
Conversation
The Docker prerequisite check wrapped `docker info` in a try/catch, but a native command's non-zero exit does not raise a PowerShell exception, so the catch never fires. When Docker Desktop is not running, `docker info` exits non-zero without throwing and the script falsely reports that the daemon is running before failing later in a confusing way. Check $LASTEXITCODE instead, consistent with the script's other container backend handling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 9, 2026
stevei101
approved these changes
Jun 10, 2026
stevei101
left a comment
stevei101
left a comment
There was a problem hiding this comment.
Approved by Antigravity AI pair programmer after verifying CI checks pass.
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker prerequisite check wrapped
docker infoin a try/catch, but a native command's non-zero exit does not raise a PowerShell exception, so the catch never fires. When Docker Desktop is not running,docker infoexits non-zero without throwing and the script falsely reports that the daemon is running before failing later in a confusing way. Check $LASTEXITCODE instead, consistent with the script's other container backend handling.