[codex] fix Hookify prompt fields and warning context#67084
Open
nyxst4ck wants to merge 1 commit into
Open
Conversation
0b50bcb to
7dabee3
Compare
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event: prompt+pattern:rules to the currentUserPromptSubmitpayload field,promptuser_promptas a backward-compatible alias for existing ruleshookSpecificOutput.additionalContextto Hookify warning responses for hook events that support context injection, so Claude sees warnings instead of only the user seeingsystemMessageWhy
The current hooks reference documents
UserPromptSubmitinput asprompt, while older Hookify rules and an open PR useduser_prompt. This keeps both forms working while makingpromptthe primary field.Hookify
warnrules also returned onlysystemMessage, which is visible to the user but does not give Claude context to adjust its behavior. AddingadditionalContextfixes the issue reported in #20747 without auto-approvingPreToolUsepermissions.Related: #59151
Fixes #20747
Tests
python -m unittest plugins.hookify.tests.test_prompt_field_mapping plugins.hookify.tests.test_warning_contextpython -m compileall -q plugins\hookifygit diff --check upstream/main...HEAD