fix(ralph-wiggum): case-insensitive completion promise matching#67753
Open
nahrinoda wants to merge 1 commit into
Open
fix(ralph-wiggum): case-insensitive completion promise matching#67753nahrinoda wants to merge 1 commit into
nahrinoda wants to merge 1 commit into
Conversation
…and whitespace-tolerant Promise matching previously used exact string comparison, causing false negatives when Claude output casing differed from the configured promise (e.g. "Complete" vs "COMPLETE") or when YAML parsing introduced extra whitespace. Both sides are now normalized and lowercased before comparison. Uses tr for portability with macOS default Bash 3. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompletevsCOMPLETE)trinstead of${var,,}for portability with macOS default Bash 3Problem
The stop hook used exact string comparison for completion promises. This caused loops to continue unnecessarily when:
<promise>Complete</promise>but the promise was set toCOMPLETETest plan
COMPLETEvsComplete) — matchesDONEvsDONE) — matchesSUCCESSvsCOMPLETE) — correctly rejects${var,,}syntax)🤖 Generated with Claude Code