Fix subscription event delivery when some subscriptions expire#53
Open
prog-supdex wants to merge 3 commits intoanycable:masterfrom
Open
Fix subscription event delivery when some subscriptions expire#53prog-supdex wants to merge 3 commits intoanycable:masterfrom
prog-supdex wants to merge 3 commits intoanycable:masterfrom
Conversation
Contributor
Author
|
GitHub workflow installs graphql 2.5 (here GraphQL-Ruby ~> 2.3), which brings stricter validation for subscriptions here and here According to the validations, subscription operations must have only one root field subscription SomeSubscription {
productCreated { id title }
productUpdated { id }
}I have updated the tests (stat_spec and anycable_spec) to follow this limitation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #52
Before this fix, if a subscription expired after checking at the existing moment during processing, no events would be delivered to any subscribers