Skip to content

fix: limit bulk indexing error log to a single summary instead of per-item logging #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weited merged 1 commit into from
Mar 12, 2026
Merged

fix: limit bulk indexing error log to a single summary instead of per-item logging #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/main/java/au/org/aodn/oceancurrent/util/elasticsearch/BulkRequestProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,19 @@ private void executeWithRetry(BulkRequest request) {
BulkResponse response = esClient.bulk(request);
log.info("Bulk indexing completed");
if (response.errors()) {
log.error("Bulk indexing has errors!");
response.items().forEach(item -> {
int maxSamples = 5;
long errorCount = 0;
List<String> errorSamples = new ArrayList<>();
for (var item : response.items()) {
if (item.error() != null) {
log.error("Error for item: {}", item.error().reason());
errorCount++;
if (errorSamples.size() < maxSamples) {
errorSamples.add(item.error().type() + ": " + item.error().reason());
}
}
});
}
log.error("Bulk indexing completed with {}/{} errors. Sample errors (first {}): {}",
errorCount, response.items().size(), maxSamples, errorSamples);
}
return;
} catch (IOException e) {
Expand Down
Loading