-
Notifications
You must be signed in to change notification settings - Fork 369
add AmsAssignService and ZkBucketAssignStore to implement balanced bucket allocation in master-slave mode #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3922 +/- ##
============================================
+ Coverage 29.00% 29.22% +0.22%
- Complexity 3850 3915 +65
============================================
Files 631 630 -1
Lines 50770 50997 +227
Branches 6543 6518 -25
============================================
+ Hits 14724 14906 +182
- Misses 34989 35039 +50
+ Partials 1057 1052 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
|
Please conduct a code review of the implementation here. |
Why are the changes needed?
This implements the logic for dynamically and evenly distributing buckets based on the number of AMS nodes.
Close #3921 .
Brief change log
AmsAssignService Functionality
ZkBucketAssignStore Features
/{cluster}/amoro/ams/bucket-assignments/{nodeKey}/assignmentsand/{cluster}/amoro/ams/bucket-assignments/{nodeKey}/last-update-timetwo classes that work together to implement dynamic bucket ID allocation and storage in master-slave mode.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation