Skip to content

Conversation

@simonsssu
Copy link
Contributor

Close #3940

@github-actions github-actions bot added the module:ams-server Ams server module label Nov 14, 2025
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, could you please add a test to cover this case

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.95%. Comparing base (cbdc517) to head (1826537).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../amoro/server/manager/FlinkOptimizerContainer.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3941      +/-   ##
============================================
+ Coverage     22.12%   28.95%   +6.82%     
- Complexity     2461     3879    +1418     
============================================
  Files           445      632     +187     
  Lines         40897    50675    +9778     
  Branches       5767     6464     +697     
============================================
+ Hits           9050    14671    +5621     
- Misses        31089    34974    +3885     
- Partials        758     1030     +272     
Flag Coverage Δ
core 28.95% <50.00%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Flink config load will cause ClassCastException when directly use Yaml load.

4 participants