-
Notifications
You must be signed in to change notification settings - Fork 369
[AMORO-3943] Shade all third party classes for spark runtime #3942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cc @zhoujinsong |
zhoujinsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment, PTAL.
| <exclude>META-INF/services/org.apache.spark.sql.sources.DataSourceRegister</exclude> | ||
| </excludes> | ||
| </filter> | ||
| <filter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we manege the filter in the plugin manager like :https://github.com/apache/amoro/blob/master/pom.xml#L1560
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would not work once we override the configuration in sub module
Why are the changes needed?
Close #3943.
all not shaded class
org.apache.thrift
org.apache.commons.io
com.github.benmanes
org.threeten from orc-core https://github.com/apache/orc/tree/main/java/core/src/java/org/threeten
others:
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
all classes shaded

Documentation