Skip to content

Conversation

@zhangwl9
Copy link
Contributor

@zhangwl9 zhangwl9 commented Nov 27, 2025

Why are the changes needed?

Close #3971.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:mixed-trino trino module for Mixed Format type:build labels Nov 27, 2025
@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 2 times, most recently from dafa018 to a85cdfe Compare November 27, 2025 05:54
@github-actions github-actions bot removed the module:mixed-trino trino module for Mixed Format label Nov 27, 2025
@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 2 times, most recently from 9d7a47f to c7364ee Compare November 27, 2025 06:23
@xxubai
Copy link
Contributor

xxubai commented Nov 27, 2025

releated to amoro-shade: apache/amoro-shade#3

@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 2 times, most recently from 302c487 to f5c6997 Compare November 27, 2025 06:51
@zhangwl9
Copy link
Contributor Author

releated to amoro-shade: apache/amoro-shade#3
I need to wait for amoro-shade-zookeeper to be merged first, and then update amoro-shade-jackson to 2.15.0. Only then I can update the relevant reference versions in the amoro project.

@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 2 times, most recently from bb55b91 to 909f7ea Compare November 27, 2025 07:26
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.94%. Comparing base (99ecf53) to head (909f7ea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3976      +/-   ##
============================================
- Coverage     29.14%   28.94%   -0.21%     
+ Complexity     3921     3877      -44     
============================================
  Files           638      632       -6     
  Lines         50937    50676     -261     
  Branches       6545     6464      -81     
============================================
- Hits          14846    14668     -178     
+ Misses        35030    34978      -52     
+ Partials       1061     1030      -31     
Flag Coverage Δ
core 28.94% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 3 times, most recently from 4bc0134 to 68cd129 Compare November 28, 2025 02:05
@turboFei
Copy link
Member

could you update the dependencies list.

./dev/dependencies.sh --replace

@zhangwl9
Copy link
Contributor Author

@xxubai
I noticed you've updated the Shade version in https://github.com/apache/amoro-shade/tree/update-0.9-snapshot, but when Amoro runs the compilation, it can't access these new Shade version JAR files. What else needs to be done? You can upload the new version to the location specified in the error report.

image

@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 3 times, most recently from 33b37c7 to d234b61 Compare December 5, 2025 10:29
@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch 2 times, most recently from f488787 to 8c4e5b2 Compare December 5, 2025 12:40
@zhangwl9 zhangwl9 force-pushed the AMORO-fixup-highCVE-dev branch from 8c4e5b2 to 233300b Compare December 8, 2025 03:48
@zhangwl9
Copy link
Contributor Author

zhangwl9 commented Dec 8, 2025

The compilation error is as follows:
image
We must await the release of the maven-shade 0.9-snapshot version. Only after obtaining the jar file for this version from the following path (https://repository.apache.org/content/groups/snapshots/org/apache/amoro/amoro-shade-zookeeper-3/) can compilation proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Fix some high CVEs

4 participants