-
Notifications
You must be signed in to change notification settings - Fork 369
[AMORO-3989] Amoro's support for the domestic database Damang #3992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
xxubai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the unit tests
93d8588 to
1657fb5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3992 +/- ##
============================================
- Coverage 22.12% 7.80% -14.33%
+ Complexity 2461 895 -1566
============================================
Files 445 639 +194
Lines 40897 51508 +10611
Branches 5767 6545 +778
============================================
- Hits 9050 4019 -5031
- Misses 31089 47233 +16144
+ Partials 758 256 -502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
91da4a4 to
7c134d5
Compare
| <dependency> | ||
| <groupId>com.dameng</groupId> | ||
| <artifactId>DmJdbcDriver18</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think Dameng needs to be included in the release. Similar to MySQL, users who need it can add the JDBC dependency manually, rather than having it as a standard component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think Dameng needs to be included in the release. Similar to MySQL, users who need it can add the JDBC dependency manually, rather than having it as a standard component.
Aleady modified!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xxubai Thanks for your review. Do you have any other suggestions
7c134d5 to
6b2aa2d
Compare
a106090 to
99a9f0d
Compare

[AMORO-3989] Amoro's support for the domestic database Damang