[bug]:TaskRuntime.stateLock and TableOptimizingProcess.lock can cause deadlocks. #4002
+21
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
TaskRuntime.stateLock and TableOptimizingProcess.lock can cause deadlocks.This can cause tables in a certain resource group to malfunction, and OptimizerKeeper will also fail to function properly.
Close #4001.
Brief change log
Fixes Implemented:
The following fixes have been implemented:
completeTaskmethod (lines 565-577):taskRuntime.complete()(acquire and release the database lock).TableOptimizingProcess.this.lockand callacceptResult.TableOptimizingProcess.this.lockfirst, then acquire the database lock.whenCompletedcallback registration (lines 910-922 and 932-945):acceptResultwhile holding the database lock.acceptResultwithincompleteTask.cancelTasksmethod (lines 897-902):First, cancel all tasks (acquire and release the database lock).
Then call
acceptResultfor each canceled task (while holdingTableOptimizingProcess.this.lock).How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation