Skip to content

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Dec 25, 2025

[AMORO-4022] [Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module (#4022)

Why are the changes needed?

Close #4022 .

Brief change log

  • TableMaintainer interface remove to amoro-common
  • Add TableMaintainerContext、MaintainerMetrics、OptimizingInfo interface
  • Impl DefaultTableMaintainerContext
  • MixedTableMaintainer & IcebergTableMaintainer remove to amoro-iceberg
  • Iceberg Maintainer Test from ams move to amoro-iceberg (executor can't remove to amoro-iceberg,execute in ams and tests)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Dec 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 1.68919% with 291 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.24%. Comparing base (cbdc517) to head (831eccb).
⚠️ Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
.../amoro/formats/iceberg/utils/IcebergTableUtil.java 0.00% 80 Missing ⚠️
...moro/formats/iceberg/utils/RollingFileCleaner.java 0.00% 60 Missing ⚠️
...ats/iceberg/maintainer/IcebergTableMaintainer.java 0.00% 54 Missing ⚠️
...rmats/iceberg/maintainer/MixedTableMaintainer.java 0.00% 44 Missing ⚠️
...zing/maintainer/DefaultTableMaintainerContext.java 0.00% 26 Missing ⚠️
.../optimizing/maintainer/TableMaintainerFactory.java 0.00% 14 Missing ⚠️
...server/optimizing/maintainer/TableMaintainers.java 0.00% 4 Missing ⚠️
...org/apache/amoro/maintainer/MaintainerMetrics.java 0.00% 4 Missing ⚠️
...va/org/apache/amoro/maintainer/OptimizingInfo.java 0.00% 4 Missing ⚠️
...che/amoro/server/table/TableOptimizingMetrics.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4024      +/-   ##
============================================
+ Coverage     22.12%   29.24%   +7.11%     
- Complexity     2461     4319    +1858     
============================================
  Files           445      697     +252     
  Lines         40897    56794   +15897     
  Branches       5767     7121    +1354     
============================================
+ Hits           9050    16610    +7560     
- Misses        31089    38928    +7839     
- Partials        758     1256     +498     
Flag Coverage Δ
core 28.61% <1.68%> (?)
trino 22.44% <0.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@czy006 czy006 changed the title Draft: [AMORO-4022] [Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module [AMORO-4022] [Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module Dec 26, 2025
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your improvement.

@czy006 czy006 requested a review from baiyangtx December 31, 2025 02:33
@czy006 czy006 force-pushed the issues/AMORO-4022 branch from c3c426c to 3026fcf Compare January 6, 2026 07:34
@czy006 czy006 force-pushed the issues/AMORO-4022 branch from 3026fcf to 831eccb Compare January 6, 2026 07:34
@czy006 czy006 requested a review from xxubai January 6, 2026 07:35
@czy006 czy006 merged commit 23fb957 into apache:master Jan 7, 2026
13 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module

4 participants