Respect fullnameOverride

[dvarrazzo]

Not all the resources handle fullnameOverride consistently. Most of them just use the release name.

In the following example, whatever should appear in no resource name:

$ helm template whatever --set fullnameOverride=foo ./charts/apisix-ingress-controller | yq --no-doc '.metadata.name + "/" + .kind'
whatever/ServiceAccount
whatever-ingress-config/ConfigMap
whatever-apisix-ingress-manager-role/ClusterRole
whatever-apisix-ingress-metrics-auth-role/ClusterRole
whatever-apisix-ingress-metrics-reader/ClusterRole
whatever-apisix-ingress-manager-rolebinding/ClusterRoleBinding
whatever-apisix-ingress-metrics-auth-rolebinding/ClusterRoleBinding
whatever-apisix-ingress-leader-election-role/Role
whatever-apisix-ingress-leader-election-rolebinding/RoleBinding
foo/Service
foo/Deployment
apisix/IngressClass

after the fix:

$ helm template whatever --set fullnameOverride=foo ./charts/apisix-ingress-controller | yq --no-doc '.metadata.name + "/" + .kind'
foo/ServiceAccount
foo-ingress-config/ConfigMap
foo-manager-role/ClusterRole
foo-metrics-auth-role/ClusterRole
foo-metrics-reader/ClusterRole
foo-manager-rolebinding/ClusterRoleBinding
foo-metrics-auth-rolebinding/ClusterRoleBinding
foo-leader-election-role/Role
foo-leader-election-rolebinding/RoleBinding
foo/Service
foo/Deployment
apisix/IngressClass

The MR also remove the redundant apisix-ingress part from the roles and bindings (previous names would have been like apisix-ingress-controller-apisix-ingress-manager-role) and fixes the volume names in the deployment.

[javier-ruiz-voxsmart]

it will be awesome to have this fixed. We are using ArgoCD in combination with AppSet and If we want to change the name of our ArgoCD application this will imply a recreation.