fix(radixtree_host_uri): add route id to service-fetch failure log#13723
Open
AlinsRan wants to merge 1 commit into
Open
fix(radixtree_host_uri): add route id to service-fetch failure log#13723AlinsRan wants to merge 1 commit into
AlinsRan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a route with no
hosts/hostreferences a service that cannot be fetched,push_host_routerlogs:without the referencing route id, so an operator has no way to locate which route holds the dangling reference. The sibling
filter_funcerror in the same file already logsroute id: <id>; this aligns the service-fetch error to the same format.This is not a routing-match bug. The route tree is rebuilt on demand (any request after a route/service version change triggers a full rebuild), and the rebuild iterates every route — so the error is emitted with the log context of whatever request triggered the rebuild, not the offending route. That is by design: the route with the missing service keeps matching as an only-uri route (
missing service won't affect the route matching), traffic is unaffected. A dangling route→service reference only arises from user-side data: deleting a service with?force=true(which bypasses the delete_checker) or writing to etcd directly, or a transient route/service watch ordering skew that self-heals. This PR only closes the diagnosability gap so the offending route can be found; it does not change matching behavior.Fixes #13552
Checklist