Skip to content

fix(xds): do not log 'no keys' as an error when an xds key has no data #13758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlinsRan wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

fix(xds): do not log 'no keys' as an error when an xds key has no data #13758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apisix/core/config_xds.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@ function _M.new(key, opts)
err = ok2
end

if err then
-- "no keys" means the xds key has no data yet, not a failure; the
-- periodic fetch loop above already treats it as non-error
if err and err ~= "no keys" then
log.error("failed to fetch data from xds ",
err, ", ", key)
end
Expand Down
Loading