Skip to content

GH-48654: [Python] Test timestamp from int without pandas dependency #48655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HyukjinKwon wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −12
Open

GH-48654: [Python] Test timestamp from int without pandas dependency #48655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 37 additions & 12 deletions python/pyarrow/tests/test_convert_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,18 +1381,13 @@ def test_sequence_timestamp_nanoseconds():
23, 34, 123456)


@pytest.mark.pandas
@pytest.mark.timezone_data
def test_sequence_timestamp_from_int_with_unit():
# TODO(wesm): This test might be rewritten to assert the actual behavior
# when pandas is not installed

data = [1]

s = pa.timestamp('s')
ms = pa.timestamp('ms')
us = pa.timestamp('us')
ns = pa.timestamp('ns')

arr_s = pa.array(data, type=s)
assert len(arr_s) == 1
Expand All @@ -1418,22 +1413,52 @@ def test_sequence_timestamp_from_int_with_unit():
)
assert str(arr_us[0]) == "1970-01-01 00:00:00.000001"

expected_exc = TypeError

class CustomClass():
pass

for ty in [pa.timestamp('ns'), pa.date32(), pa.date64()]:
with pytest.raises(expected_exc):
pa.array([1, CustomClass()], type=ty)


@pytest.mark.pandas
@pytest.mark.timezone_data
def test_sequence_timestamp_from_int_with_unit_nanosecond():
# With pandas installed, nanosecond timestamps return pd.Timestamp
# with full nanosecond precision (see scalar.pxi in _datetime_from_int)
import pandas as pd

data = [1]
ns = pa.timestamp('ns')

arr_ns = pa.array(data, type=ns)
assert len(arr_ns) == 1
assert arr_ns.type == ns
assert repr(arr_ns[0].as_py()) == (

result = arr_ns[0].as_py()
assert isinstance(result, pd.Timestamp)
assert repr(result) == (
"Timestamp('1970-01-01 00:00:00.000000001')"
)
assert str(arr_ns[0]) == "1970-01-01 00:00:00.000000001"

expected_exc = TypeError

class CustomClass():
pass
@pytest.mark.nopandas
@pytest.mark.timezone_data
def test_sequence_timestamp_from_int_nanosecond_without_pandas():
# Without pandas, nanosecond timestamps raise ValueError if value
# is not safely convertible to microseconds (value % 1000 != 0)
data = [1]
ns = pa.timestamp('ns')

for ty in [ns, pa.date32(), pa.date64()]:
with pytest.raises(expected_exc):
pa.array([1, CustomClass()], type=ty)
arr_ns = pa.array(data, type=ns)
assert len(arr_ns) == 1
assert arr_ns.type == ns

with pytest.raises(ValueError, match="not safely convertible to microseconds"):
arr_ns[0].as_py()


def test_sequence_duration():
Expand Down
Loading