[CALCITE-7197] UnsupportedOperationException when using dynamic parameters inside ROW expression #4553
Conversation
…eters inside ROW expression
strongduanmu
force-pushed
the
dev-CALCITE-7197
branch
from
473fa49 to
e324648
Compare
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
| boolean inferred = false; | ||
| for (SqlNode child : nodeList) { | ||
| if (child instanceof SqlBasicCall && SqlKind.ROW == child.getKind()) { |
There was a problem hiding this comment.
There are expressions that evaluate to a ROW type that are not ROW expressions.
For example, a[1], where a is an array of ROW values.
There was a problem hiding this comment.
Thanks for bringing this up, I might not have considered it before. Can you give a sql example? I will continue to analyze the possible problems in this scenario.
There was a problem hiding this comment.
See https://issues.apache.org/jira/browse/CALCITE-7231 for an example
| LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { 7499, 30 }, { null, 20 }, { null, 5 }]]) | ||
| LogicalAggregate(group=[{0, 1}]) | ||
| LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { null, 20 }, { null, 5 }, { 7499, 30 }]]) | ||
| LogicalValues(tuples=[[{ 1, 2 }, { null, 20 }, { 3, null }, { 7369, null }, { 7499, 30 }, { null, 5 }]]) |
There was a problem hiding this comment.
Maybe what I want to ask is this—why has the order changed here? Is this necessary?
There was a problem hiding this comment.
Yes, it's neccessay. This order is generated by the UnionToValuesRule rule based on planBefore. For details, see the corresponding relationship in the following figure.
|
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
4 participants
Ref https://issues.apache.org/jira/browse/CALCITE-7197