ci: use Go 1.25.x in validate and regen workflows#2924
Merged
Conversation
golang.org/x/net 0.55.0 bumps require go >= 1.25.0 in the Go modules (script/generator already on main via apache#2909, crds and script/validator pending in apache#2904/apache#2901), while setup-go installed 1.24.x with GOTOOLCHAIN=local, breaking the Run Generator/Run Validator steps. Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Failed runs:
Build Regenonmain(broken since chore(deps): bump golang.org/x/net from 0.40.0 to 0.55.0 in /script/generator #2909 merged): https://github.com/apache/camel-kamelets/actions/runs/29242574108validateon PR chore(deps): bump golang.org/x/net from 0.40.0 to 0.55.0 in /crds #2904: https://github.com/apache/camel-kamelets/actions/runs/28943759525/job/85872217216Errors Found
The Dependabot bumps of
golang.org/x/net0.40.0 → 0.55.0 raise thegodirective to1.25.0in each Go module (script/generatoralready on main via #2909;/crdspending in #2904;/script/validatorpending in #2901), butactions/setup-gowas pinned togo-version: 1.24.xand v6 setsGOTOOLCHAIN=local, which forbids toolchain auto-upgrade. This currently breaks theRun Generatorstep ofmain-push-regen.yamlon every push tomain, and thevalidatejob on the pending Dependabot PRs.Fix Applied
go-version: 1.24.x→1.25.xin.github/workflows/validate.yamland.github/workflows/main-push-regen.yaml. Go 1.25 still builds thego 1.24.6modules, so this is safe to merge ahead of the remaining Dependabot PRs.Verified locally with a ≥1.25 toolchain and
GOTOOLCHAIN=local: the generator module on main builds, andgo run . ../../kamelets/(the exactvalidatecommand) passes on PR #2904 content once the validator module is aligned by #2901.Suggested merge order for the pending Dependabot PRs
@dependabot rebasechore(deps): bump golang.org/x/net from 0.40.0 to 0.55.0 in /script/validator #2901 (validator) → merge — its diff already carries thego 1.25.0directive andx/net/x/textbumps the module graph needs@dependabot rebasechore(deps): bump golang.org/x/net from 0.40.0 to 0.55.0 in /crds #2904 (crds) → merge — itsvalidateonly goes green after chore(deps): bump golang.org/x/net from 0.40.0 to 0.55.0 in /script/validator #2901, because the validator'sgo.modmust recordx/net v0.55.0selected via the local../../crdsreplaceDeferred Issues
None — single root cause.
🤖 Generated with Claude Code on behalf of Andrea Cosentino (@oscerd)