Skip to content

feat: Ensure extension is created with camel-base metadatas#8467

Open
gansheer wants to merge 2 commits intoapache:mainfrom
gansheer:feat/5191-make-camel-version-visible
Open

feat: Ensure extension is created with camel-base metadatas#8467
gansheer wants to merge 2 commits intoapache:mainfrom
gansheer:feat/5191-make-camel-version-visible

Conversation

@gansheer
Copy link
Copy Markdown
Contributor

@gansheer gansheer commented Mar 24, 2026

Ref #5191
Ref quarkusio/quarkus#35404

Add the 'integrates' new metadata field filled by default with camel-base artifact reference with a version referencing the property. version: "${camel.version}" stays as-is in source (NOT replaced).

Then the version value is added by the maven-resources-plugin. The changes in build:

  • Applies to the implicit default-resources execution
  • Says: "Copy everything from src/main/resources EXCEPT META-INF/quarkus-extension.yaml"
  • Other files (like quarkus-extension.properties) are still copied normally

The Maven Build Process does the following:

  1. Default Resources (default-resources execution)
    Process: src/main/resources/**
    EXCEPT: META-INF/quarkus-extension.yaml (excluded)
    Result: Other files copied to target/classes/

  2. Legal Resources (legal-resources execution)
    Copies license files with filtering

  3. Filter Extension Metadata (filter-extension-metadata execution)
    Process: ONLY META-INF/quarkus-extension.yaml
    Filtering: true
    Reads: "${camel.version}" from pom properties
    Replaces: "${camel.version}" → "4.19.0"
    Result: Filtered file in target/classes/META-INF/

@gansheer
Copy link
Copy Markdown
Contributor Author

I will resolve the conflict when the PR review is done.

Copy link
Copy Markdown
Contributor

@zbendhiba zbendhiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gansheer gansheer marked this pull request as draft April 13, 2026 18:44
@gansheer gansheer force-pushed the feat/5191-make-camel-version-visible branch from d42d10e to 2ef8506 Compare April 17, 2026 18:05
@gansheer gansheer requested a review from ppalaga April 17, 2026 18:11
@gansheer gansheer marked this pull request as ready for review April 17, 2026 18:15
@gansheer
Copy link
Copy Markdown
Contributor Author

Adapted to new design: quarkusio/quarkus-platform-bom-generator#415 (comment)

Comment thread poms/build-parent/pom.xml Outdated
Comment on lines +139 to +145
<resources>
<resource>
<directory>${project.basedir}/src/main/resources</directory>
<excludes>
<exclude>META-INF/quarkus-extension.yaml</exclude>
</excludes>
</resource>
Copy link
Copy Markdown
Contributor

@ppalaga ppalaga Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<resources>
<resource>
<directory>${project.basedir}/src/main/resources</directory>
<excludes>
<exclude>META-INF/quarkus-extension.yaml</exclude>
</excludes>
</resource>
<resources>
<resource>
<directory>${project.basedir}/src/main/resources</directory>
<excludes>
<exclude>META-INF/quarkus-extension.yaml</exclude>
</excludes>
<filtering>false</filtering>
</resource>
<resource>
<directory>${project.basedir}/src/main/resources</directory>
<includes>
<include>META-INF/quarkus-extension.yaml</include>
</includes>
<filtering>true</filtering>
</resource>

You can do it all in one block

@gansheer gansheer force-pushed the feat/5191-make-camel-version-visible branch from 2ef8506 to dd6410d Compare April 20, 2026 11:40
@jamesnetherton
Copy link
Copy Markdown
Contributor

What's the status of this? Is it mergeable? Or are we waiting on something from the Quarkus side?

@gansheer
Copy link
Copy Markdown
Contributor Author

What's the status of this? Is it mergeable? Or are we waiting on something from the Quarkus side?

Let me squash correctly first for ease of backport.

@gansheer gansheer force-pushed the feat/5191-make-camel-version-visible branch from 3eb1279 to dc9a910 Compare April 21, 2026 07:57
@gansheer
Copy link
Copy Markdown
Contributor Author

@jamesnetherton It's good for me now.

@gansheer gansheer requested a review from ppalaga April 21, 2026 13:29
@apupier
Copy link
Copy Markdown
Contributor

apupier commented Apr 27, 2026

@gansheer there are conflicts to resolve

@gansheer gansheer force-pushed the feat/5191-make-camel-version-visible branch from dc9a910 to 788d9a7 Compare April 27, 2026 14:14
@jamesnetherton
Copy link
Copy Markdown
Contributor

Is this safe to merge without the associated Quarkus issues being complete?

@gansheer
Copy link
Copy Markdown
Contributor Author

Is this safe to merge without the associated Quarkus issues being complete?

Let's wait, that's probably safer.

@gansheer
Copy link
Copy Markdown
Contributor Author

Waiting for next release of https://github.com/quarkusio/quarkus-platform-bom-generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants