feat: Ensure extension is created with camel-base metadatas#8467
feat: Ensure extension is created with camel-base metadatas#8467gansheer wants to merge 2 commits intoapache:mainfrom
Conversation
|
I will resolve the conflict when the PR review is done. |
d42d10e to
2ef8506
Compare
|
Adapted to new design: quarkusio/quarkus-platform-bom-generator#415 (comment) |
| <resources> | ||
| <resource> | ||
| <directory>${project.basedir}/src/main/resources</directory> | ||
| <excludes> | ||
| <exclude>META-INF/quarkus-extension.yaml</exclude> | ||
| </excludes> | ||
| </resource> |
There was a problem hiding this comment.
| <resources> | |
| <resource> | |
| <directory>${project.basedir}/src/main/resources</directory> | |
| <excludes> | |
| <exclude>META-INF/quarkus-extension.yaml</exclude> | |
| </excludes> | |
| </resource> | |
| <resources> | |
| <resource> | |
| <directory>${project.basedir}/src/main/resources</directory> | |
| <excludes> | |
| <exclude>META-INF/quarkus-extension.yaml</exclude> | |
| </excludes> | |
| <filtering>false</filtering> | |
| </resource> | |
| <resource> | |
| <directory>${project.basedir}/src/main/resources</directory> | |
| <includes> | |
| <include>META-INF/quarkus-extension.yaml</include> | |
| </includes> | |
| <filtering>true</filtering> | |
| </resource> | |
You can do it all in one block
2ef8506 to
dd6410d
Compare
|
What's the status of this? Is it mergeable? Or are we waiting on something from the Quarkus side? |
Let me squash correctly first for ease of backport. |
3eb1279 to
dc9a910
Compare
|
@jamesnetherton It's good for me now. |
|
@gansheer there are conflicts to resolve |
dc9a910 to
788d9a7
Compare
|
Is this safe to merge without the associated Quarkus issues being complete? |
Let's wait, that's probably safer. |
|
Waiting for next release of https://github.com/quarkusio/quarkus-platform-bom-generator. |
Ref #5191
Ref quarkusio/quarkus#35404
Add the 'integrates' new metadata field filled by default with camel-base artifact reference with a version referencing the property.
version: "${camel.version}"stays as-is in source (NOT replaced).Then the version value is added by the maven-resources-plugin. The changes in build:
default-resourcesexecutionsrc/main/resourcesEXCEPTMETA-INF/quarkus-extension.yaml"quarkus-extension.properties) are still copied normallyThe Maven Build Process does the following:
Default Resources (default-resources execution)
Process: src/main/resources/**
EXCEPT: META-INF/quarkus-extension.yaml (excluded)
Result: Other files copied to target/classes/
Legal Resources (legal-resources execution)
Copies license files with filtering
Filter Extension Metadata (filter-extension-metadata execution)
Process: ONLY META-INF/quarkus-extension.yaml
Filtering: true
Reads: "${camel.version}" from pom properties
Replaces: "${camel.version}" → "4.19.0"
Result: Filtered file in target/classes/META-INF/