Add test coverage for Gmail DataType Transformers : update-message-labels and draft#8625
Add test coverage for Gmail DataType Transformers : update-message-labels and draft#8625JinyuChen97 wants to merge 1 commit intoapache:mainfrom
Conversation
| <dependency> | ||
| <groupId>org.apache.camel.quarkus</groupId> | ||
| <artifactId>camel-quarkus-direct</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
The -deployment dependency needs adding into the virtualDependencies profile. You can run this from the project root to add it:
mvn process-resources -Pformat -N
JinyuChen97
force-pushed
the
camel-quarkus-8531
branch
from
97c68bb to
7edec4c
Compare
|
The pr implementation looks good, maybe a few questions about the intent. Do we need that level of test verbosity ? For instance, what does those camel-quarkus tests bring compared to camel tests ? |
It's a good point. I'd say not, unless there's something about a feature that might cause it to behave differently in CQ. E.g different dependency versions, use of reflection or other stuff problematic for native mode.
We already have that. Given the work is already done, I am ok merging this. It was actually a useful exercise because it's likely nobody has run any of the Google tests for 6+ years 🙈 (they are disabled without the relevant credentials being set). |
| Message response = producerTemplate.requestBodyAndHeaders("google-mail://messages/get", null, headers, | ||
| Message.class); | ||
| if (response != null && response.getPayload() != null && response.getPayload().getHeaders() != null) { | ||
| for (com.google.api.services.gmail.model.MessagePartHeader header : response.getPayload().getHeaders()) { |
There was a problem hiding this comment.
Please use imports in all cases and avoid FQCN references where possible.
…bels and draft
- google-mail:update-message-labels transformer: Tests automatic label name-to-ID
resolution when updating message labels via exchange variables
- google-mail:draft transformer: Tests draft creation and update using
GoogleMailStreamConstants headers (MAIL_FROM, MAIL_TO, MAIL_SUBJECT, etc.)
- Threading metadata support: Tests draft replies with proper threadId and
Message-ID headers for email threading
All added tests pass in both JVM and native modes.
Generated with Claude Code on behalf of Jinyu Chen
fixes apache#8531
JinyuChen97
force-pushed
the
camel-quarkus-8531
branch
from
7edec4c to
1a8b0f6
Compare
Ok, that's fine to merge then. And it's always possible to clean up in another ticket anyway. Like we could keep the gmail tests and just remove the data type transformer part if make sense. |
3 participants
Add test coverage for Gmail DataType Transformers : update-message-labels and draft
google-mail:update-message-labels transformer: Tests automatic label name-to-ID resolution when updating message labels via exchange variables
google-mail:draft transformer: Tests draft creation and update using GoogleMailStreamConstants headers (MAIL_FROM, MAIL_TO, MAIL_SUBJECT, etc.)
Threading metadata support: Tests draft replies with proper threadId and Message-ID headers for email threading
All added tests pass with real google cloud environment in both JVM and native modes.
Generated with Claude Code on behalf of Jinyu Chen
fixes #8531