chore(camel-test-infra-docling): upgrade docling.container to v1.30.0 - #25471
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
fba447a to
80191df
Compare
Since docling v1.30.0, page furniture (headers/footers) is included in the default body export. Update the sentinel test assertion in OcrExtractionIT to expect this new behavior and update the documentation note accordingly. Supersedes #25417. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
80191df to
c67e658
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 12 tested, 28 compile-only — current: 11 all testedMaveniverse Scalpel detected 40 affected modules (current approach: 11).
|
gnodet
left a comment
There was a problem hiding this comment.
Clean container upgrade from docling-serve v1.29.0 to v1.30.0 with correctly adapted test assertion and documentation.
Verified:
- Version bump follows established pattern (14+ prior docling container upgrades in git history).
- The 36 deletions are fully justified: old documentation had a lengthy workaround section (referencing upstream issue #271, suggesting document restructuring) that is no longer needed since furniture is now included by default. Test similarly had explanatory comments replaced with shorter ones.
- Container image (
quay.io/docling-project/docling-serve:v1.30.0) hosted on quay.io (not Docker Hub), aligning with project convention. - Architecture support correctly handled:
skipITs.s390x=trueandskipITs.ppc64le=truealready set (image only supports amd64/arm64). - Catalog copies and metadata.json consistently updated.
- CI green on both JDK 17 and JDK 25.
- The sentinel test pattern worked exactly as designed — the original
assertFalsewas documented as a canary that would fire when a future docling release includes page furniture. It fired, and this PR correctly responds.
One minor observation (non-blocking): The documentation states the furniture-layer inclusion is an intentional v1.30.0 feature, but the upstream docling-serve v1.30.0 release notes don't explicitly mention this change, and upstream issue docling-serve#271 for content-layer control remains open. The behavior is real (confirmed by IT results) but may be an undocumented side effect of other changes in bundled docling v2.118.0 rather than a guaranteed feature. Worth noting in case it gets reverted in a future release.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of @gnodet
Summary
OcrExtractionIT.testOcrWithMultipleTextBlockssentinel assertion: docling v1.30.0 now includes page furniture (headers/footers) in the default body export, so the test now asserts footer text is present (was previously asserting it was absent)docling-component.adocto reflect the new behaviorSupersedes #25417 which had merge conflicts. Addresses the behavioral change flagged by @gnodet's local IT results.
Test plan
Claude Code on behalf of davsclaus
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com