Conversation
Member
|
@sagilio please review |
|
|
- Added CasbinAuthorizeAttribute constructor with 13 parameters - Added CasbinAuthorizeAttribute constructor with 14 parameters - Added generic CasbinAuthorizeAttribute<T1...T13> class - Added generic CasbinAuthorizeAttribute<T1...T14> class This fixes the issue where the Casbin.NET 2.19.1 upgrade added support for 14 parameters in StringRequestValues but the attribute constructors only supported up to 12 parameters. Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix wrong version of package pushed to NuGet for PR #69
Add missing 13 and 14 parameter constructors for CasbinAuthorizeAttribute
Jan 3, 2026
hsluoyz
added a commit
that referenced
this pull request
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #69 updated Casbin.NET from 2.5.3 to 2.19.1, which extended
StringRequestValuesto support 14 parameters. However,CasbinAuthorizeAttributeconstructors were incomplete—only supporting up to 12 parameters. This caused the published NuGet package to contain incorrect IL code.Changes
Both follow the existing constructor chaining pattern established in parameters 5-12.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.myget.org/usr/bin/dotnet dotnet restore(dns block)/usr/bin/dotnet dotnet build src/Casbin.AspNetCore/Casbin.AspNetCore.csproj -c Release(dns block)/usr/bin/dotnet dotnet test test/Casbin.AspNetCore.Tests/Casbin.AspNetCore.Tests.csproj -c Release --verbosity normal(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.