Merged
Conversation
belliottsmith
force-pushed
the
fixes-251228
branch
from
910c6f6 to
6cd3d19
Compare
ifesdjeen
approved these changes
Jan 14, 2026
|
|
||
| public abstract class IdEntry extends TxnId | ||
| { | ||
| static final int SAVE_SATUS_SHIFT = Status.Durability.ENCODING_BITS; |
| @Override | ||
| IdEntry copy() | ||
| { | ||
| accord.impl.cfr.IdSingleEntry copy = new accord.impl.cfr.IdSingleEntry(this, range); |
Contributor
There was a problem hiding this comment.
nit: do not need to fully qualify here
| { | ||
| if (!force | ||
| && updated.saveStatus() == prev.saveStatus() | ||
| && (updated.saveStatus().known.executeAt().isDecided() && !prev.saveStatus().known.executeAt().isDecided()) |
Contributor
There was a problem hiding this comment.
how can isDecided be different if save statuses are identity-equal?
belliottsmith
force-pushed
the
fixes-251228
branch
2 times, most recently
from
3e2fbe3 to
12efa00
Compare
Also Fix: - DefaultLocalListeners iterators do not handle multiple waiters on the same transaction correctly - Minor burn test edge case when cancelling bootstrap and resuming - NotifyWaitingOn stillExecutes->stillWaitsOn - Privileged fast path commit failure should not send stable message - Erroneously populating executeAt with txnId in CommandSummaries for Accepted commands Also Improve: - Improve Catchup logging - KeyDeps.forEach - Timestamp.tryParse - Simulate CFR loading/listening patch by Benedict; reviewed by Alex Petrov for CASSANDRA-21306
belliottsmith
force-pushed
the
fixes-251228
branch
from
12efa00 to
6567fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InMemoryRangeIndex: Cassandra's secondary range index integration appears to be faulty in some way, producing sync points that have missing dependencies. Introduce a burn-test integrated in-memory implementation we can be more efficiently confident in.
Also:
- SemiSyncValue
- Simulate CFR loading/listening
- KeyDeps.forEach
- Timestamp.tryParse
Fix:
- Minor burn test edge case when cancelling bootstrap and resuming
- NotifyWaitingOn stillExecutes->stillWaitsOn
- Privileged fast path commit failure should not send stable message
- DefaultLocalListeners iterators do not handle multiple waiters on the same transaction correctly
Improve:
- Don't compute Deps for SyncPoint Accept or Recover phase
- Catchup should report bounds to progress log