[Test] CI: add binary swap CI for REL_2_STABLE #1522
Conversation
tuhaihe
force-pushed
the
binary-swap-ci-rel2-clean
branch
from
df3d64c to
8cac6b5
Compare
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
Hi, amazing work! No doubt! I made some comments. They are optional. I just do not understand all the nuances and asked for more details.
| - name: Checkout Baseline Code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ needs.resolve-baseline.outputs.baseline_version }} |
There was a problem hiding this comment.
Well, if it's the baseline version and has a tag. Maybe the RPM has already been uploaded and we don't need to build it again?
| steps: | ||
| - name: Free Disk Space | ||
| run: | | ||
| echo "=== Disk space before cleanup ===" |
There was a problem hiding this comment.
Let's place all the commands below in the devops directory and reuse the script in every place where we need to clear the host data. (Since we already use it in build-cloudberry.yml, it can be done in a separate PR.)
There was a problem hiding this comment.
No problem. Will create a new PR to update it.
|
|
||
| CREATE TABLE sales_partition_heap_part3 | ||
| PARTITION OF sales_partition_heap | ||
| FOR VALUES IN ('Processing'); |
There was a problem hiding this comment.
Should we also check if AO/AOCO tables work as expected?
tuhaihe
force-pushed
the
binary-swap-ci-rel2-clean
branch
2 times, most recently
from
5ae6f4b to
dcbca29
Compare
1. Use test_binary_swap.sh for testing 2. Integrate with parallel builds in workflow 3. Update terminology (Master -> Coordinator) 4. Add build script injection for compatibility
tuhaihe
force-pushed
the
binary-swap-ci-rel2-clean
branch
from
cc181b0 to
ababd95
Compare
2 participants
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions