B&R: Show backup offerings with userDrivenBackupsAllowed=false to all users

[abh1sar]

Description

This PR fixes #11878

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. Set allowuserdrivenbackups=false
2. list backup offerings as a normal user
3. Verified that the offering is showing
4. Verified that assign offering to an instance is also working as the user
5. Verified that create backup is failing with the error "The assigned backup offering does not allow ad-hoc user backup"

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (8b9f5fd) to head (b04d744).
⚠️ Report is 114 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #11889      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
+ Complexity    15533    15531       -2     
============================================
  Files          5909     5909              
  Lines        528970   529006      +36     
  Branches      64602    64602              
============================================
- Hits          92917    92912       -5     
- Misses       425603   425646      +43     
+ Partials      10450    10448       -2     

Flag	Coverage Δ
uitests	3.58% <ø> (-0.01%)	⬇️
unittests	18.63% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vishesh92]

clgtm

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16329

[blueorangutan]

[SF] Trillian test result (tid-15165)
Environment: kvm-ol9 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 58921 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11889-t15165-kvm-ol9.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	Failure	45.32	test_kubernetes_clusters.py

[vishesh92]

lgtm. Tested the listing in the dashboard for a normal user for backup offerings. Before, non-user driver backup offerings were not showing up in the dropdown. After the changes, it's listing all the backup offerings.