Fix: Condition for aborting migration, resume paused VMs on destination #12331

nvazquez · 2025-12-24T02:17:48Z

Description

This PR addresses the following:

Change the logic for checking if the sleepTime is absolutely equal to 1s to greater than or equal to 1s in case of thread’s duration skips to make it more robust
In the Abort Migration logic, it only checks for VMs in Running state. This doesn’t allow migration to be aborted if the VM has already been paused by the ‘Pause VM’ logic below it and migration still hasn’t completed by the timeout for aborting migration has been reached.
Resuming the VM on the destination host on migration successfully completing if it is in the Paused state -- avoiding manual restart of the VM upon successful migration.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

nvazquez · 2025-12-24T02:19:44Z

@blueorangutan package

blueorangutan · 2025-12-24T02:22:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-12-24T02:25:39Z

Codecov Report

❌ Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (b394b5b) to head (3f1cf04).
⚠️ Report is 23 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...resource/wrapper/LibvirtMigrateCommandWrapper.java	6.45%	28 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.20   #12331    +/-   ##
==========================================
  Coverage     16.23%   16.23%            
- Complexity    13377    13380     +3     
==========================================
  Files          5657     5657            
  Lines        498865   499017   +152     
  Branches      60545    60566    +21     
==========================================
+ Hits          80991    81033    +42     
- Misses       408843   408949   +106     
- Partials       9031     9035     +4

Flag	Coverage Δ
uitests	`4.03% <ø> (+0.02%)`	⬆️
unittests	`17.09% <6.45%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-12-24T03:44:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16145

DaanHoogland · 2025-12-24T07:57:00Z

...vm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java

+                DomainState dmState = null;
+                try {
+                    dmState = destDomain.getInfo().state;
+                } catch (final LibvirtException e) {
+                    logger.info("Failed to get domain state for VM: " + vmName + " due to: " + e.getMessage());
+                }
+
+                if (dmState == DomainState.VIR_DOMAIN_PAUSED) {
+                    logger.info("Resuming VM " + vmName + " on destination after migration");
+                    try {
+                        destDomain.resume();
+                    } catch (final Exception e) {
+                        logger.error("Failed to resume vm " + vmName + " on destination after migration due to : " + e.getMessage());
+                    }
+                }


new method..?

abh1sar · 2025-12-28T12:37:11Z

...vm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java

                    final int migrateDowntime = libvirtComputingResource.getMigrateDowntime();
                    if (migrateDowntime > 0 ) {
                        try {
                            final int setDowntime = dm.migrateSetMaxDowntime(migrateDowntime);


I don't think we need to call this every 100ms. We can use a variable to check and call this block only once.

@nvazquez would you consider making this change?

Sure, thanks @abh1sar sorry for the delay, I have refactored it accordingly

nvazquez · 2026-01-08T03:31:08Z

@blueorangutan test

blueorangutan · 2026-01-08T03:32:05Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-08T18:54:56Z

[SF] Trillian test result (tid-15139)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12331-t15139-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_list_system_vms_metrics_history	`Failure`	0.18	test_metrics_api.py

nvazquez · 2026-01-15T04:15:18Z

Thanks @abh1sar @DaanHoogland I addressed your comments

@blueorangutan package

blueorangutan · 2026-01-15T04:16:34Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-15T05:10:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16369

Fix: Condition for aborting migration, resume paused VMs on destination

0960b4c

nvazquez added this to the 4.20.3 milestone Dec 24, 2025

nvazquez requested review from DaanHoogland, Pearl1594 and kiranchavala December 24, 2025 02:17

boring-cyborg bot added the component:kvm label Dec 24, 2025

nvazquez requested a review from abh1sar December 24, 2025 02:18

DaanHoogland reviewed Dec 24, 2025

View reviewed changes

abh1sar approved these changes Dec 28, 2025

View reviewed changes

nvazquez added 2 commits January 15, 2026 00:25

Refactor downtime logic

b204e5b

Refactor into new method

3f1cf04

Fix: Condition for aborting migration, resume paused VMs on destination #12331

Are you sure you want to change the base?

Fix: Condition for aborting migration, resume paused VMs on destination #12331

Conversation

nvazquez commented Dec 24, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Dec 24, 2025

Uh oh!

blueorangutan commented Dec 24, 2025

Uh oh!

codecov bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Dec 24, 2025

Uh oh!

DaanHoogland Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

abh1sar Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

abh1sar Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

nvazquez Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

nvazquez commented Jan 15, 2026

Uh oh!

blueorangutan commented Jan 15, 2026

Uh oh!

blueorangutan commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 24, 2025 •

edited

Loading