Skip to content

Conversation

@Damans227
Copy link
Contributor

@Damans227 Damans227 commented Jan 13, 2026

Description

When registering a CKS data ISO for all zones, if any zone lacks secondary storage, the registration fails but leaves an orphaned ISO in zones that do have storage. This requires manual cleanup.

Fixes: #10994

This PR adds upfront validation to check that secondary storage exists before attempting to register the ISO:

  • If a specific zone is provided, validates that zone has secondary storage
  • If no zone is provided (registering for all zones), validates all zones have secondary storage and reports which zones are missing it.

Fixes: #10994

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

N/A

How Has This Been Tested?

  • Added unit tests for validateImageStoreForZone method.
  • Manual testing against KVM based 4.20 environment.

@Damans227 Damans227 changed the title Add image store validation for Kubernetes version registration CKS: Add image store validation for Kubernetes version registration Jan 13, 2026
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (6a324da) to head (18f1ce1).

Files with missing lines Patch % Lines
...bernetes/version/KubernetesVersionManagerImpl.java 85.71% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12418   +/-   ##
=========================================
  Coverage     16.23%   16.24%           
- Complexity    13382    13388    +6     
=========================================
  Files          5657     5657           
  Lines        498999   499020   +21     
  Branches      60566    60572    +6     
=========================================
+ Hits          81035    81051   +16     
- Misses       408928   408930    +2     
- Partials       9036     9039    +3     
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.09% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants