Add MS Edge Chromium support

[RedMickey]

Hello,
I am a maintainer of Cordova Tools VS Code extension and Cordova-Simulate tool. We use the cordova-serve package in Cordova-Simulate for simulating Apache Cordova applications on different platforms (Android, iOS) in the browser.

Platforms affected

• Microsoft Edge based on Chromium

Motivation and Context

We have an issue about adding support of MS Edge Chromium. Since in Cordova-Simulate we use the cordova-serve package for launching apps in the browser, we consider that it makes sense to add a support of Edge Chromium to cordova-serve instead of making a local enhancement on Cordova-Simulate side. Also we think that it would be a useful enhancement for the cordova-serve package which allows to use the package for serving Cordova apps in MS Edge Chromium.

Description

Since the old Edge browser had become deprecated we added support of launching MS Edge Chromium on Windows and macOS.
This is a breaking change, since we removed support of non Chromium MS Edge browser. As seen Microsoft is promoting MS Edge Chromium browser and trying to replace the previous version of Edge which is not based on Chromium. We think that sooner or later the old Edge will be completely replaced on all the systems, so this PR could prepare the package to that change.

Related issues: microsoft/cordova-simulate#325

[codecov-io]

Codecov Report

Merging #40 (4d41b6d) into master (ea89b6e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   28.11%   28.11%           
=======================================
  Files           6        6           
  Lines         217      217           
=======================================
  Hits           61       61           
  Misses        156      156           

Impacted Files	Coverage Δ
src/browser.js	18.60% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea89b6e...4d41b6d. Read the comment docs.

[RedMickey]

Hi @erisu, could you please review this PR?

[timbru31]

The problem I see with this PR: Until End of March 2021 the old browser is still supported by MS - is there a clever way to support both browsers? Otherwise this PR marks a breaking change.

[RedMickey]

The problem I see with this PR: Until End of March 2021 the old browser is still supported by MS - is there a clever way to support both browsers? Otherwise this PR marks a breaking change.

Hi @timbru31, I rolled back some changes, so now the package supports both Edge browsers (old and chromium based).

[SounD120]

Hi @erisu , @timbru31 . Could you please take a look on this PR?

[timbru31]

The code looks good to me on a first review, I'd like to do some testing before merging though.

[RedMickey]

Hi @erisu, @timbru31. Could you please take a look at this PR?

[seamlink-aalves]

Any chance of having this merged and a new version created?

[EzioLi01]

Do we still have any plan to merge this? Thanks!

[EzioLi01]

Hey @timbru31, I'm not sure if you are still working on this project, but do we still have any plan on this?

[codecov-commenter]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️