Skip to content

[WIP] fix: do not ignore test SPARK-48037 #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kazuyukitanimura wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] fix: do not ignore test SPARK-48037 #2774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions dev/diffs/3.5.7.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1770,16 +1770,6 @@ index 2f8e401e743..a4f94417dcc 100644
CostEvaluator.instantiate(
classOf[SimpleShuffleSortCostEvaluator].getCanonicalName, spark.sparkContext.getConf)
intercept[IllegalArgumentException] {
@@ -2417,7 +2457,8 @@ class AdaptiveQueryExecSuite
}

test("SPARK-48037: Fix SortShuffleWriter lacks shuffle write related metrics " +
- "resulting in potentially inaccurate data") {
+ "resulting in potentially inaccurate data",
+ IgnoreComet("https://github.com/apache/datafusion-comet/issues/1501")) {
withTable("t3") {
withSQLConf(
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
@@ -2452,6 +2493,7 @@ class AdaptiveQueryExecSuite
val (_, adaptive) = runAdaptiveAndVerifyResult(query)
assert(adaptive.collect {
Expand Down
10 changes: 0 additions & 10 deletions dev/diffs/4.0.1.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,16 +2392,6 @@ index 272be70f9fe..06957694002 100644
CostEvaluator.instantiate(
classOf[SimpleShuffleSortCostEvaluator].getCanonicalName, spark.sparkContext.getConf)
intercept[IllegalArgumentException] {
@@ -2513,7 +2552,8 @@ class AdaptiveQueryExecSuite
}

test("SPARK-48037: Fix SortShuffleWriter lacks shuffle write related metrics " +
- "resulting in potentially inaccurate data") {
+ "resulting in potentially inaccurate data",
+ IgnoreComet("too many shuffle partitions causes Java heap OOM")) {
withTable("t3") {
withSQLConf(
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
@@ -2548,6 +2588,7 @@ class AdaptiveQueryExecSuite
val (_, adaptive) = runAdaptiveAndVerifyResult(query)
assert(adaptive.collect {
Expand Down
Loading