Skip to content

bug: Eliminate dead round-robin insertion in enforce distribution #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Dec 11, 2025
Merged

bug: Eliminate dead round-robin insertion in enforce distribution #19132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82f0a3f
eliminate adding round robin repartition condition in the if parent r…
gene-bordegaray Dec 6, 2025
cafca64
Merge branch 'main' into gene.bordegaray/2025/12/eliminate_unused_rou…
alamb Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions datafusion/physical-optimizer/src/enforce_distribution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,11 +1274,6 @@ pub fn ensure_distribution(
}
Distribution::HashPartitioned(exprs) => {
// See https://github.com/apache/datafusion/issues/18341#issuecomment-3503238325 for background
Copy link
Contributor

@alamb alamb Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this comment too?

Copy link
Contributor Author

@gene-bordegaray gene-bordegaray Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will update this documentation to be accurate. I think it is still useful for people who want to dive into this part of the codebase

if add_roundrobin && !hash_necessary {
// Add round-robin repartitioning on top of the operator
// to increase parallelism.
child = add_roundrobin_on_top(child, target_partitions)?;
}
// When inserting hash is necessary to satisfy hash requirement, insert hash repartition.
if hash_necessary {
child =
Expand Down