Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 7, 2025

Which issue does this PR close?

Rationale for this change

I want to ensure we have test coverage for constant value lookup tables in the SLT tests

What changes are included in this PR?

  1. Add some more slt tests that use constant value lookup tables (e.g. when the case values are all constants)

I also ran

cargo llvm-cov test --html  --test sqllogictests -- case

To ensure this was covering the new code

Are these changes tested?

Only tests

Are there any user-facing changes?

NO

@alamb alamb marked this pull request as ready for review December 7, 2025 13:02
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 7, 2025
@alamb alamb added this pull request to the merge queue Dec 8, 2025
@alamb
Copy link
Contributor Author

alamb commented Dec 8, 2025

Thanks @rluvaton

Merged via the queue into apache:main with commit dd35f7c Dec 8, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants