chore: update 6 crates to rust edition 2024 #19196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Dec 10, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I reviewed the whitespace blind version: https://github.com/apache/datafusion/pull/19196/files?w=1
Looks good to me. Thank you @timsaucer for driving this along
FWIW since this PR will be a conflict magnet I recommend resolving the conflicts and then merging it as soon as possible
(sorry I actually reviewed this yesterday but forgot to hit submit on the review)
Member
Author
Thanks. Will do. |
timsaucer
force-pushed
the
chore/upgrade-rust-2024-group-5
branch
from
eacf226 to
861981c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This addresses part of #15804 but does not close it.
Rationale for this change
Now that we are on MSRV 1.88 we can use rust edition 2024, which brings let chains and other nice features. It also improves
unsafechecking. In order to introduce these changes in slower way instead of one massive PR that is too difficult to manage we are updating a few crates at a time.What changes are included in this PR?
Updates these crates to 2024.
Are these changes tested?
Existing unit tests. There are no functional code changes.
Are there any user-facing changes?
None.
Note
It is recommended to review with the ignore whitespace setting: https://github.com/apache/datafusion/pull/19196/files?w=1