add benchmarks for single column group-values traits#23070
Open
Rich-T-kid wants to merge 1 commit into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
this PR works towards #9195
see comment #9195 (comment)
Rationale for this change
there is a lack of benchmarks for the singlar
GroupValuetraits. #22004 was added a little while ago and when looking for optimizations for #9195 i noticed there wasn't a way to measure improvement. I went ahead and included benchmarks for the other single column types besidesGroupsValueByteView.What changes are included in this PR?
benchmarks for all single-column
GroupValuestraits.Are these changes tested?
N/a
Are there any user-facing changes?
no