chore: gate internal_datafusion_err import behind the proto feature#23075
Open
Phoenix500526 wants to merge 1 commit into
Open
chore: gate internal_datafusion_err import behind the proto feature#23075Phoenix500526 wants to merge 1 commit into
internal_datafusion_err import behind the proto feature#23075Phoenix500526 wants to merge 1 commit into
Conversation
`internal_datafusion_err` is only used in `DynamicFilterPhysicalExpr::try_from_proto`, which are only compiled when feature proto is enabled. Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — a trivial build-warning fix, no tracking issue.
Rationale for this change
Building
datafusion-physical-exprwithout theprotofeature emits anunused importwarning:internal_datafusion_erris only referenced insideimpl DynamicFilterPhysicalExpr { fn try_from_proto(..) }, which is itself gatedbehind
#[cfg(feature = "proto")]. The import was unconditional, so it becamedead whenever
protois disabled.What changes are included in this PR?
Move the
internal_datafusion_errimport behind#[cfg(feature = "proto")]so itis compiled only when its sole use site is, matching the existing gate on the
try_from_protoimpl block.Are these changes tested?
No new tests — this is a compile-time-only change. It is exercised by existing CI,
which builds the crate both with and without the
protofeature; the warning(promoted to an error under
-D warnings) no longer fires.Are there any user-facing changes?
No.
🤖 Generated with Claude Code