fix: drop dynamic filter in hash-join when swap inputs#23078
Open
haohuaijin wants to merge 3 commits into
Open
fix: drop dynamic filter in hash-join when swap inputs#23078haohuaijin wants to merge 3 commits into
haohuaijin wants to merge 3 commits into
Conversation
Dandandan
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
HashJoinExec::swap_inputspreserves old dynamic filter after swap #23077Rationale for this change
Dynamic filters are runtime state tied to the probe side.
swap_inputschanges the probe side, so preserving the old filter is unsafe and can lead to wrong column references.What changes are included in this PR?
remove the
dynamic_filterwhile swap inputs inHashJoinExec:Are these changes tested?
yes, add one test case
Are there any user-facing changes?
no