docs: update proto-models README for the datafusion-common dependency - #24279
Open
adriangb wants to merge 2 commits into
Open
docs: update proto-models README for the datafusion-common dependency#24279adriangb wants to merge 2 commits into
adriangb wants to merge 2 commits into
Conversation
`datafusion-proto-models` now depends on `datafusion-common` and hosts the `From` / `TryFrom` conversions between the generated proto types and their `datafusion-common` counterparts, but the crate README still claimed it had no DataFusion dependencies beyond `datafusion-proto-common` and exposed only the generated structs. Describe the conversions and why they live in this crate, and spell out the narrowness that still holds: `datafusion-common` and `datafusion-proto-common` are the only DataFusion dependencies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GoAdfGfHwhLreDPDQ9GoDK
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24279 +/- ##
==========================================
+ Coverage 81.05% 81.29% +0.24%
==========================================
Files 1107 1110 +3
Lines 381574 385311 +3737
Branches 381574 385311 +3737
==========================================
+ Hits 309281 313246 +3965
+ Misses 54034 53580 -454
- Partials 18259 18485 +226 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
approved these changes
Aug 12, 2026
| between those types and the [`datafusion-common`] types they mirror. The | ||
| conversions live here because their DataFusion side sits _below_ this crate in | ||
| the dependency graph and so cannot host the impls itself — the same arrangement | ||
| [`datafusion-proto-common`] uses for `ScalarValue` and `Statistics`. |
Contributor
There was a problem hiding this comment.
I recommend adding a link to the relevant context / definition for ScaalrValue / Statistics as well
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
github-actions
Bot
removed
the
documentation
adriangb
enabled auto-merge
August 12, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datafusion-proto-modelsnow depends ondatafusion-commonand hosts theFrom/TryFromconversions between the generated proto types and theirdatafusion-commoncounterparts, but the crate README still claimed it had no DataFusion dependencies beyonddatafusion-proto-commonand exposed only the generated structs.Describe the conversions and why they live in this crate, and spell out the narrowness that still holds:
datafusion-commonanddatafusion-proto-commonare the only DataFusion dependencies.