feat(parquet): clip nested wrappers during schema pruning - #24315
Open
buraksenn wants to merge 1 commit into
Open
feat(parquet): clip nested wrappers during schema pruning#24315buraksenn wants to merge 1 commit into
buraksenn wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24315 +/- ##
========================================
Coverage 81.14% 81.15%
========================================
Files 1110 1110
Lines 386137 386318 +181
Branches 386137 386318 +181
========================================
+ Hits 313347 313518 +171
- Misses 54324 54330 +6
- Partials 18466 18470 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ListView/Dictionary/FixedSizeListwrappers in nested schema pruning #24122.Rationale for this change
Parquet nested schema pruning currently descends through
Struct,List, andLargeList. Narrowing casts throughListView,LargeListView,FixedSizeList, orDictionarytherefore read physical leaves that the cast never consumes.The issue also listed
RunEndEncoded, but its casts do not use DataFusion's name-based nested cast path. Arrow may map nested struct fields positionally, so clipping those values could change results; they must remain a full read.What changes are included in this PR?
Extend nested schema pruning through matching
ListView,LargeListView,FixedSizeList, andDictionarywrappers while preserving safe full-read fallbacks.Are these changes tested?
Yes, with new and existing tests.
Are there any user-facing changes?
No.