fix(ui): guard against empty plugin prop on connection creation page#8918
Merged
Conversation
veetmoradiya3628
approved these changes
Jun 12, 2026
veetmoradiya3628
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
klesh
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8914
What happened
When clicking "New Connection" from the connection list modal, the
pluginstate was still an empty string
''whenConnectionFormrendered. Thiscaused
getPluginConfig('')to return a fallback config with an emptyname,leading to:
TypeError: Cannot read properties of undefined (reading 'name')
Root Cause
In
connections.tsx,handleShowFormDialogsettype = 'form'but didnot ensure
pluginwas set. The form modal only checkedpluginConfigbutnot
pluginitself, soConnectionFormreceived an empty string as thepluginprop.Changes
config-ui/src/routes/connection/connections.tsxplugin &&guard to the form modal condition to preventConnectionFormfrom rendering with an empty pluginconfig-ui/src/plugins/components/connection-form/index.tsx?? {}fallback ongetPluginConfigdestructuringif (!plugin || !name) return nullguard after all hooksas a defensive measure
How to Test