fix(webhook): set resolution_date and lead_time_minutes on incident c…#8919
Merged
Conversation
Contributor
Author
|
Hi @klesh could you please approve pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8906
What happened
When closing an incident via the webhook API (
POST /plugins/webhook/:connectionId/issue/:issueKey/close), theresolution_datefield was never set on either theissuesorincidentstable. The DORA FDRT (Failed Deployment Recovery Time) metric is calculated fromincidents.resolution_date, so incidents closed this way never appeared in the DORA dashboard.Root Cause
In
backend/plugins/webhook/api/issues.go, thecloseIssuefunction setStatustoDONEand clearedOriginalStatusfor both the issue and incident records, but never setResolutionDateor recalculatedLeadTimeMinutes.Changes
backend/plugins/webhook/api/issues.goResolutionDatetotime.Now()if not already set when closing an issueLeadTimeMinutesfromCreatedDatetoResolutionDateif not already set when closing an issue